fix: cancel timer when immediate setState comes in #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I now notice this goes against the original documented behavior of the component. I've updated the README to reflect its new behavior, but am open to disagreement on what the real desired behavior for most engineers will be. My personal expectation is that it should behave as this PR suggests... I've created use-delay-follow-state to reflect this behavior, as well as adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
This tries to address the following code flow:
I believe most developers' expectation would be that the second setState cancels the ongoing timer (i.e. you shouldn't get "hi" after you then asked for an immediate setState to "bye"). This attempts to fix that.
I've also fixed all lint errors and updated the safe browser list to the latest.
Test Plan
Updated the example code,
npm start, and verify that the example continues to run correctly.